-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Alpine from 3.13 to 3.15 #18050
Conversation
Have alpine sorted the reason why we had to downgrade back to 3.13 last year? If not have sufficient numbers of people upgraded their dockers to prevent it from being problem? |
This should help with the issue described in #17994 related to old npm. |
Let me be clearer: Alpine 3.14+ will cause everyone using gitea with docker less than version 20.10.6 to break. (https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0) We upgraded to alpine 3.14 and had multiple bug reports like: #16428, #16451, #16170, #16464, #16484 See: https://about.gitlab.com/blog/2021/08/26/its-time-to-upgrade-docker-engine/ For when gitlab were finally bitten by this. |
So the question is has enough of the docker community moved over to update their docker installs and have they been bitten elsewhere yet? One option is to do this but also add a check in to Gitea that will check if this bug is present and report that we cannot run. |
That's a lot of new information for me, too. If we can write the background in comment, maybe new developers won't have questions anymore. |
So looking at: alpinelinux/docker-alpine#156 (comment) & alpinelinux/docker-alpine#156 (comment) May provide techniques for us to test at time of docker run if things are going to be broken.
|
Docker is just a dependency in this case. We should document its minimum version and possible refuse to run if it's too old. Question is, can a container detect the version of the docker daemon it runs on? |
this might do it |
Signed-off-by: Andrew Thornton <art27@cantab.net>
* 'main' of https://github.com/go-gitea/gitea: Change initial TrustModel to committer (go-gitea#18335) refactor httplib (go-gitea#18338) Propagate context and ensure git commands run in request context (go-gitea#17868) Upgrade Alpine from 3.13 to 3.15 (go-gitea#18050) [skip ci] Updated translations via Crowdin Stop trimming preceding and suffixing spaces from editor filenames (go-gitea#18334) [skip ci] Updated translations via Crowdin Left-Align text in Unicode warning boxes (go-gitea#18331) Only warn on bidi but still escape non-bidi (go-gitea#18333) Fix incorrect OAuth message (go-gitea#18332) [skip ci] Updated translations via Crowdin Changelog for 1.16.0-rc1 (go-gitea#18309)
* Upgrade alpine to 3.15 * Add executability test to entrypoint for too old dockers Signed-off-by: Andrew Thornton <art27@cantab.net> * Update docker/rootless/usr/local/bin/docker-entrypoint.sh Co-authored-by: zeripath <art27@cantab.net>
Upgrade Alpine from 3.13 to 3.15
Users with docker version < 20.10.6 have to upgrade their docker.
See: https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0 & https://about.gitlab.com/blog/2021/08/26/its-time-to-upgrade-docker-engine/